AppStd/DbFirst
8
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor: add TODOs for generic repository pattern

Browse Source 
Added TODO comments in ICatalogRepository and CatalogRepository to suggest adopting a generic repository pattern to reduce code duplication. Also noted the potential move of the interface to the application layer for better adherence to clean architecture principles.
This commit is contained in:
tekh
2026-01-16 13:30:30 +01:00
parent cca6af814e
commit 15680746b0
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
DbFirst.Domain/Repositories/ICatalogRepository.cs
View File

@@ -2,6 +2,8 @@ using DbFirst.Domain.Entities;
namespace DbFirst.Domain.Repositories; namespace DbFirst.Domain.Repositories;
// TODO: instead of creating interface per entity, consider using generic repository pattern (eg. IRepository<T>) to reduce code duplication.
//TODO: move to application layer as a part of clean architecture
public interface ICatalogRepository public interface ICatalogRepository
{ {
Task<List<VwmyCatalog>> GetAllAsync(CancellationToken cancellationToken = default); Task<List<VwmyCatalog>> GetAllAsync(CancellationToken cancellationToken = default);

2
DbFirst.Infrastructure/Repositories/CatalogRepository.cs
View File

@@ -6,7 +6,7 @@ using System.Data;
namespace DbFirst.Infrastructure.Repositories; namespace DbFirst.Infrastructure.Repositories;
// TODO: instead of creating implementation of repository per entity, consider using generic repository pattern (eg. IRepository<T>) to reduce code duplication. // TODO: instead of creating implementation of repository per entity, consider using generic repository pattern (eg. Repository<T>) to reduce code duplication.
public class CatalogRepository : ICatalogRepository public class CatalogRepository : ICatalogRepository
{ {
private readonly ApplicationDbContext _db; private readonly ApplicationDbContext _db;